LibreGaming/matchbot
LibreGaming
/
matchbot
15
1
Fork 1
Code Issues Pull Requests Projects Releases 3 Activity

Improve reliability and quality of the system namespace #1

Merged
seabass merged 4 commits from seabass/matchbot:system-improvements into master 2022-03-26 15:05:32 +01:00
Conversation 3 Commits 4 Files Changed 2 +1 -6
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit fecd09c656 - Show all commits

7
src/system.clj
View File

@ -34,11 +34,6 @@
(yaml/parse-stream datafile))
(catch Exception e nil)))
(defn system []
{:config nil
:state nil
:irc nil})
(defn start [system]
sm2n marked this conversation as resolved Outdated
sm2n commented 2022-03-23 20:18:29 +01:00
Outdated
Review
Copy Link

start doesn't actually use its input as far as I can tell? I think it'd be better to use _ as the binding name here since that is the case.

`start` doesn't actually use its input as far as I can tell? I think it'd be better to use _ as the binding name here since that is the case.
seabass commented 2022-03-23 20:54:44 +01:00
Outdated
Review
Copy Link

I was imagining that, in the future, this could be used to pass custom options to a single instance for development purposes, and also eventually for the main function to read the config and pass it in rather than system/start doing it by itself. Do you have any preference here? For now, yes, I agree it would be better to use _ as the binding name.

I was imagining that, in the future, this could be used to pass custom options to a single instance for development purposes, and also eventually for the main function to read the config and pass it in rather than `system/start` doing it by itself. Do you have any preference here? For now, yes, I agree it would be better to use `_` as the binding name.
sm2n commented 2022-03-23 21:14:57 +01:00
Outdated
Review
Copy Link

No, I don't have a preference here. I think what you said makes sense with regards to custom options etc. Feel free to mark this resolved.

No, I don't have a preference here. I think what you said makes sense with regards to custom options etc. Feel free to mark this resolved.
seabass commented 2022-03-24 23:08:47 +01:00
Outdated
Review
Copy Link

Resolved in commit 91cbdb69da.

Resolved in commit 91cbdb69da.
(let [config (load-config "config.yaml")
state (atom (load-state (:data-file config)))
@ -58,7 +53,7 @@
(defn restart [system-var]
(do
(alter-var-root system-var stop)
(alter-var-root system-var (constantly system))
(alter-var-root system-var (constantly nil))
sm2n marked this conversation as resolved Outdated
sm2n commented 2022-03-23 20:19:27 +01:00
Outdated
Review
Copy Link

No reason for this either, I think? As the system value isn't used for start, and running stop multiple times is safe.

No reason for this either, I think? As the system value isn't used for `start`, and running `stop` multiple times is safe.
seabass commented 2022-03-24 23:10:00 +01:00
Outdated
Review
Copy Link

I've just made commit 91cbdb69da - is this what you had in mind?

I've just made commit 91cbdb69da - is this what you had in mind?
(alter-var-root system-var start)))
(defn -main [& args]