Use strings instead of keywords for game names #6

seabass · 2022-03-30T15:54:42+02:00

seabass commented

2022-03-30 15:54:42 +02:00

This pull request resolves issue #2.

Commits

Use strings instead of keywords for game names

This commit changes the internal representation of game names in the state data to be strings instead of keywords. This fixes a potential memory leak relating to games that no longer have any players, since strings, unlike keywords, are garbage collected when no longer in use.

This pull request resolves issue https://git.libregaming.org/LibreGaming/matchbot/issues/2. # Commits ## [Use strings instead of keywords for game names](https://git.libregaming.org/seabass/matchbot/commit/6a594c5ad300eff7365bc0908b17426994d414d0) This commit changes the internal representation of game names in the state data to be strings instead of keywords. This fixes a potential memory leak relating to games that no longer have any players, since strings, unlike keywords, are garbage collected when no longer in use.

seabass added this to the 1.0.1 milestone 2022-03-30 15:54:42 +02:00

seabass added 1 commit 2022-03-30 15:54:42 +02:00

6a594c5ad3 Use strings instead of keywords for game names

This commit changes the internal representation of game names in the
state data to be strings instead of keywords. This fixes a potential
memory leak relating to games that no longer have any players, since
strings, unlike keywords, are garbage collected when no longer in use.

Resolves issue #2

Signed-off-by: Sebastian Crane <seabass-labrax@gmx.com>

seabass commented

2022-03-30 15:55:43 +02:00

@sm2n, please could you confirm that this resolves the issue you raised in #2? Then I'll make the 1.0.1 release. Thank you!

seabass added a new dependency 2022-03-30 15:56:14 +02:00

#2 Keywords interned from user input

sm2n commented

2022-03-31 00:43:59 +02:00

LGTM