LibreGaming/matchbot
LibreGaming
/
matchbot
15
1
Fork 1
Code Issues Pull Requests Projects Releases 3 Activity

Running '!add games' deletes all state data upon restarting twice #4

New Issue
Closed
opened 2022-03-28 23:12:09 +02:00 by seabass · 1 comment
seabass commented 2022-03-28 23:12:09 +02:00
Owner
Copy Link

A bug causes matchbot to fail to read its state from the serialised JSON data if it contains a game literally called games. This leads matchbot to write null to the specified JSON file when it next exits, overwriting all the stored data about players and games.

Steps to reproduce:

  1. As a user on IRC, send the command !add games to the channel which matchbot is listening in.

  2. Restart matchbot twice.

  3. Send the command !list and observe that no data is present, or observe that your chosen JSON data file (specified with the value of the data-file key in your matchbot configuration file) contains only the string null.

Those running instances of matchbot should immediately take backups of their JSON data file and update to version 1.0.1 of matchbot as soon as it is available.

A bug causes `matchbot` to fail to read its state from the serialised JSON data if it contains a game literally called `games`. This leads `matchbot` to write `null` to the specified JSON file when it next exits, overwriting all the stored data about players and games. Steps to reproduce: 1. As a user on IRC, send the command `!add games` to the channel which `matchbot` is listening in. 2. Restart `matchbot` twice. 3. Send the command `!list` and observe that no data is present, or observe that your chosen JSON data file (specified with the value of the `data-file` key in your `matchbot` configuration file) contains only the string `null`. Those running instances of `matchbot` should immediately take backups of their JSON data file and update to version 1.0.1 of `matchbot` as soon as it is available.
seabass added this to the 1.0.1 milestone 2022-03-28 23:12:09 +02:00
seabass added the
security
 label 2022-03-28 23:12:09 +02:00
seabass added a new dependency 2022-03-29 21:10:39 +02:00
#5 Fix erroneous JSON data loading
seabass commented 2022-03-29 21:17:33 +02:00
Author
Owner
Copy Link

Resolved in pull request #5.

Resolved in pull request #5.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
1.1.0
1.0.1
1.0.0
Labels
Clear labels   
security

A verified or potential vulnerability

No Label
security
Milestone
Clear milestone
No items
No Milestone
1.0.1
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Depends on
#5 Fix erroneous JSON data loading
LibreGaming/matchbot
Reference: LibreGaming/matchbot#4
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?