From 73f24add6184555567d91fdcfb0e255391800c4f Mon Sep 17 00:00:00 2001 From: rubenwardy Date: Tue, 20 Mar 2018 03:54:38 +0000 Subject: [PATCH] Add permission validation to Package.checkPerm() --- app/models.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/models.py b/app/models.py index ca77979..0021e1d 100644 --- a/app/models.py +++ b/app/models.py @@ -141,6 +141,8 @@ class Package(db.Model): if type(perm) == str: perm = Permission[perm] + elif type(perm) != Permission: + raise Exception("Unknown permission given to Package.checkPerm()") isOwner = user == self.author @@ -158,7 +160,7 @@ class Package(db.Model): return user.rank.atLeast(UserRank.MODERATOR) else: - return False + raise Exception("Permission {} is not related to packages".format(perm.name)) # Setup Flask-User db_adapter = SQLAlchemyAdapter(db, User) # Register the User model