From 607c5341749a814ee26fecdfa3401e29ffee6ce4 Mon Sep 17 00:00:00 2001 From: rubenwardy Date: Sat, 30 Jan 2021 16:50:32 +0000 Subject: [PATCH] Improve outdated messages: don't show last commit on tag triggers --- app/models/packages.py | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/app/models/packages.py b/app/models/packages.py index 34347b3..24e01a7 100644 --- a/app/models/packages.py +++ b/app/models/packages.py @@ -978,14 +978,14 @@ class PackageUpdateConfig(db.Model): if self.trigger == PackageUpdateTrigger.COMMIT: msg = "New commit {} found on the Git repo.".format(self.last_commit[0:5]) + last_release = self.package.releases.first() + if last_release and last_release.commit_hash: + msg += " The last release was commit {}".format(last_release.commit_hash[0:5]) + + return msg + else: - msg = "New tag {} found on the Git repo.".format(self.last_tag) - - last_release = self.package.releases.first() - if last_release and last_release.commit_hash: - msg += " The last release was commit {}".format(last_release.commit_hash[0:5]) - - return msg + return "New tag {} found on the Git repo.".format(self.last_tag) def get_create_release_url(self): title = self.last_tag or self.outdated_at.strftime("%Y-%m-%d")