From 441ed3beeb0fdc3540f03ddefcb7bd0c7c60769f Mon Sep 17 00:00:00 2001
From: rubenwardy <rw@rubenwardy.com>
Date: Tue, 29 Jan 2019 00:24:59 +0000
Subject: [PATCH] Add option to only change None entries with bulk change
 releases

---
 app/templates/packages/release_bulk_change.html |  1 +
 app/views/packages/releases.py                  | 11 ++++++++---
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/app/templates/packages/release_bulk_change.html b/app/templates/packages/release_bulk_change.html
index 4b21748..a51198f 100644
--- a/app/templates/packages/release_bulk_change.html
+++ b/app/templates/packages/release_bulk_change.html
@@ -23,6 +23,7 @@
 			{{ render_checkbox_field(form.set_max, class_="col-sm-2") }}
 			{{ render_field(form.max_rel, class_="col-sm-10") }}
 		</div>
+		{{ render_checkbox_field(form.only_change_none) }}
 
 		<p id="minmax_warning" style="color:#f00; display: none;">
 			Maximum must be greater than or equal to the minimum!
diff --git a/app/views/packages/releases.py b/app/views/packages/releases.py
index b461c34..f7730e2 100644
--- a/app/views/packages/releases.py
+++ b/app/views/packages/releases.py
@@ -180,6 +180,7 @@ class BulkReleaseForm(FlaskForm):
 	set_max = BooleanField("Set Max")
 	max_rel  = QuerySelectField("Maximum Minetest Version", [InputRequired()],
 			query_factory=lambda: get_mt_releases(True), get_pk=lambda a: a.id, get_label=lambda a: a.name)
+	only_change_none = BooleanField("Only change values previously set as none")
 	submit   = SubmitField("Update")
 
 
@@ -193,11 +194,15 @@ def bulk_change_release_page(package):
 	# Initial form class from post data and default data
 	form = BulkReleaseForm()
 
-	if request.method == "POST" and form.validate():
+	if request.method == "GET":
+		form.only_change_none.data = True
+	elif request.method == "POST" and form.validate():
+		only_change_none = form.only_change_none.data
+
 		for release in package.releases.all():
-			if form["set_min"].data:
+			if form["set_min"].data and (not only_change_none or release.min_rel is None):
 				release.min_rel = form["min_rel"].data.getActual()
-			if form["set_max"].data:
+			if form["set_max"].data and (not only_change_none or release.max_rel is None):
 				release.max_rel = form["max_rel"].data.getActual()
 
 		db.session.commit()