From 2f2141f524ccef326be5eb72d1a5d1f6278ca3ca Mon Sep 17 00:00:00 2001 From: rubenwardy Date: Sat, 31 Jul 2021 19:52:36 +0100 Subject: [PATCH] Allow editors to change maintainers Fixes #325 --- app/models/packages.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/app/models/packages.py b/app/models/packages.py index 8bbb1ec..ea31559 100644 --- a/app/models/packages.py +++ b/app/models/packages.py @@ -528,11 +528,9 @@ class Package(db.Model): elif perm == Permission.APPROVE_SCREENSHOT: return isMaintainer and user.rank.atLeast(UserRank.TRUSTED_MEMBER if self.approved else UserRank.NEW_MEMBER) - elif perm == Permission.EDIT_MAINTAINERS: - return isOwner or user.rank.atLeast(UserRank.MODERATOR) - - elif perm == Permission.UNAPPROVE_PACKAGE or perm == Permission.DELETE_PACKAGE: - return user.rank.atLeast(UserRank.MEMBER if isOwner else UserRank.EDITOR) + elif perm == Permission.EDIT_MAINTAINERS or perm == Permission.UNAPPROVE_PACKAGE or \ + perm == Permission.DELETE_PACKAGE: + return isOwner or user.rank.atLeast(UserRank.EDITOR) elif perm == Permission.CHANGE_RELEASE_URL: return user.rank.atLeast(UserRank.MODERATOR)