From 2bbb117eaca81b67665ec9a1224ce8fb086499b2 Mon Sep 17 00:00:00 2001
From: rubenwardy <rw@rubenwardy.com>
Date: Wed, 9 Feb 2022 19:11:31 +0000
Subject: [PATCH] Small fixes

---
 app/blueprints/packages/reviews.py            | 3 +++
 app/public/static/markdowntextarea.js         | 3 +++
 app/public/static/release_minmax.js           | 3 +++
 app/public/static/topic_discard.js            | 3 +++
 app/public/static/video_embed.js              | 3 +++
 app/templates/emails/notification_digest.html | 4 ++--
 app/templates/macros/audit_log.html           | 2 +-
 docs/dev_intro.md                             | 2 +-
 8 files changed, 19 insertions(+), 4 deletions(-)

diff --git a/app/blueprints/packages/reviews.py b/app/blueprints/packages/reviews.py
index 706f4ec..a5b194c 100644
--- a/app/blueprints/packages/reviews.py
+++ b/app/blueprints/packages/reviews.py
@@ -157,6 +157,9 @@ def delete_review(package, reviewer):
 	addNotification(package.maintainers, current_user, NotificationType.OTHER, notif_msg, url_for("threads.view", id=thread.id), package)
 
 	db.session.delete(review)
+
+	package.recalcScore()
+
 	db.session.commit()
 
 	return redirect(thread.getViewURL())
diff --git a/app/public/static/markdowntextarea.js b/app/public/static/markdowntextarea.js
index 7936fef..73b36b2 100644
--- a/app/public/static/markdowntextarea.js
+++ b/app/public/static/markdowntextarea.js
@@ -1,3 +1,6 @@
+// @author rubenwardy
+// @license magnet:?xt=urn:btih:1f739d935676111cfff4b4693e3816e664797050&dn=gpl-3.0.txt GPL-v3-or-Later
+
 $("textarea.markdown").each(function() {
 	async function render(plainText, preview) {
 		const response = await fetch(new Request("/api/markdown/", {
diff --git a/app/public/static/release_minmax.js b/app/public/static/release_minmax.js
index 559adb8..d77c07c 100644
--- a/app/public/static/release_minmax.js
+++ b/app/public/static/release_minmax.js
@@ -1,3 +1,6 @@
+// @author rubenwardy
+// @license magnet:?xt=urn:btih:1f739d935676111cfff4b4693e3816e664797050&dn=gpl-3.0.txt GPL-v3-or-Later
+
 const min = $("#min_rel");
 const max = $("#max_rel");
 const none = $("#min_rel option:first-child").attr("value");
diff --git a/app/public/static/topic_discard.js b/app/public/static/topic_discard.js
index 6e89452..a27d3d7 100644
--- a/app/public/static/topic_discard.js
+++ b/app/public/static/topic_discard.js
@@ -1,3 +1,6 @@
+// @author rubenwardy
+// @license magnet:?xt=urn:btih:1f739d935676111cfff4b4693e3816e664797050&dn=gpl-3.0.txt GPL-v3-or-Later
+
 $(".topic-discard").click(function() {
 	const ele = $(this);
 	const tid = ele.attr("data-tid");
diff --git a/app/public/static/video_embed.js b/app/public/static/video_embed.js
index c62dd5b..c449502 100644
--- a/app/public/static/video_embed.js
+++ b/app/public/static/video_embed.js
@@ -1,3 +1,6 @@
+// @author rubenwardy
+// @license magnet:?xt=urn:btih:1f739d935676111cfff4b4693e3816e664797050&dn=gpl-3.0.txt GPL-v3-or-Later
+
 document.querySelectorAll(".video-embed").forEach(ele => {
 	try {
 		const href = ele.getAttribute("href");
diff --git a/app/templates/emails/notification_digest.html b/app/templates/emails/notification_digest.html
index af5e318..3fdf268 100644
--- a/app/templates/emails/notification_digest.html
+++ b/app/templates/emails/notification_digest.html
@@ -2,7 +2,7 @@
 
 {% block content %}
 
-{% for title, group in notifications | select("package") | groupby("package.title") %}
+{% for title, group in notifications | selectattr("package") | groupby("package.title") %}
 	<h2>
 		{{ title }}
 	</h2>
@@ -17,7 +17,7 @@
 	</ul>
 {% endfor %}
 
-{% for group in notifications | reject("package") %}
+{% for group in notifications | selectattr("package", "none") %}
 	<h2>
 		{{ _("Other Notifications") }}
 	</h2>
diff --git a/app/templates/macros/audit_log.html b/app/templates/macros/audit_log.html
index 410ac0c..671fe09 100644
--- a/app/templates/macros/audit_log.html
+++ b/app/templates/macros/audit_log.html
@@ -3,7 +3,7 @@
 		{% for entry in log %}
 			<a class="list-group-item list-group-item-action"
 				{% if entry.description and current_user.rank.atLeast(current_user.rank.MODERATOR) %}
-					href="{{ url_for('admin.audit_view', id=entry.id) }}">
+					href="{{ url_for('admin.audit_view', id_=entry.id) }}">
 				{% else %}
 					href="{{ entry.url }}">
 				{% endif %}
diff --git a/docs/dev_intro.md b/docs/dev_intro.md
index 1fdc1cd..b6b9b33 100644
--- a/docs/dev_intro.md
+++ b/docs/dev_intro.md
@@ -49,7 +49,7 @@ Generally, you want to start by finding the endpoint and then seeing the code it
 
 Endpoints are sensibly organised in `app/blueprints`.
 
-You can also use a file search. For example, to find the package edit endpoint, search for `.route("/packages/<author>/<name>/edit/")`.
+You can also use a file search. For example, to find the package edit endpoint, search for `"/packages/<author>/<name>/edit/"`.
 
 
 ## Users and Permissions